Implementation for issue #445: Global forecasting support in test infrastructure#509
Closed
parth000007 wants to merge 5 commits intomllam:mainfrom
Closed
Implementation for issue #445: Global forecasting support in test infrastructure#509parth000007 wants to merge 5 commits intomllam:mainfrom
parth000007 wants to merge 5 commits intomllam:mainfrom
Conversation
Add GlobalDummyDatastore for testing global domains with all-zero boundary masks. Relax test_boundary_mask to accept both regional (mixed 0/1) and global (all-zero) boundary masks. Add test_training_global to verify end-to-end training works correctly with global domains. Closes mllam#445 Co-authored-by: Claude Sonnet 4.5 Co-authored-by: parth000007 <182992559+parth000007@users.noreply.github.com> Agent-Logs-Url: https://github.com/parth000007/neural-lam/sessions/b4634aa9-5973-4fd6-9f86-ed17ac130e75
Add global forecasting support to test infrastructure
Author
|
hi @joeloskarsson @SimonKamuk @leifdenby please review this PR and let me know the changes if required |
Contributor
|
I think this is being solved in #444 |
Author
sorry i unable to saw that PR |
Contributor
|
its better to close this one and collaborate on tht |
…asses Extract supporting components from ARModel to improve code organization: - NormalizationManager: Handles state normalization and statistical buffers - MetricTracker: Tracks validation and test metrics - ModelVisualizer: Handles all plotting and visualization logic Co-authored-by: parth000007 <182992559+parth000007@users.noreply.github.com> Agent-Logs-Url: https://github.com/parth000007/neural-lam/sessions/28caac4a-33fa-499f-9856-aa3533dfc7b4
Extract NormalizationManager, MetricTracker, and ModelVisualizer from ARModel to improve separation of concerns and code maintainability. Before: ARModel was 779 lines handling 7+ responsibilities After: ARModel is 649 lines (-17%) with 3 focused helper classes Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> Co-authored-by: parth000007 <182992559+parth000007@users.noreply.github.com> Agent-Logs-Url: https://github.com/parth000007/neural-lam/sessions/28caac4a-33fa-499f-9856-aa3533dfc7b4
…erarchy Refactor model class hierarchy: extract helper classes from ARModel
Author
okay sir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
< Summary of the changes.>
< Please also include relevant motivation and context. >
< List any dependencies that are required for this change. >
Issue Link
< Link to the relevant issue or task, if applicable > (e.g.
closes #00orsolves #00)Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee